Merge "Send 500 http status code, instead of 200, for DBConnectionErrors"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Sat, 22 Apr 2017 02:08:09 +0000 (02:08 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Sat, 22 Apr 2017 02:08:09 +0000 (02:08 +0000)
1  2 
includes/exception/MWExceptionRenderer.php

   * @author Aaron Schulz
   */
  
 +use Wikimedia\Rdbms\DBConnectionError;
 +use Wikimedia\Rdbms\DBError;
 +use Wikimedia\Rdbms\DBReadOnlyError;
 +use Wikimedia\Rdbms\DBExpectedError;
 +
  /**
   * Class to expose exceptions to the client (API bots, users, admins using CLI scripts)
   * @since 1.28
@@@ -47,10 -42,10 +47,10 @@@ class MWExceptionRenderer 
                } elseif ( self::isCommandLine() ) {
                        self::printError( self::getText( $e ) );
                } elseif ( $mode === self::AS_PRETTY ) {
+                       self::statusHeader( 500 );
                        if ( $e instanceof DBConnectionError ) {
                                self::reportOutageHTML( $e );
                        } else {
-                               self::statusHeader( 500 );
                                self::header( "Content-Type: $wgMimeType; charset=utf-8" );
                                self::reportHTML( $e );
                        }